[U-Boot] [PATCH] net: e1000: use correct hepler to do endianess conversion

Miao Yan yanmiaobest at gmail.com
Mon Dec 21 10:58:43 CET 2015


Hi Bin,

2015-12-21 17:53 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
> Hi Miao,
>
> On Mon, Dec 21, 2015 at 5:43 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> On Mon, Dec 21, 2015 at 5:04 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>> In struct e1000_rx_desc, field 'length' is declared as
>>> uint16_t, so use le16_to_cpu() to do endianess conversion.
>>>
>>> Also drop conversion on 'status' which is declared as
>>> uint8_t.
>>>
>>> Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
>>> ---
>>>  drivers/net/e1000.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> BTW: two typos,
>
> hepler in the commit title
> endianess in the commit title and body

Thanks for catching these. Will send v2.


>
> Regards,
> Bin


More information about the U-Boot mailing list