[U-Boot] [PATCH] arm: socfpga: Fix QSPI doesn't work on socdk board

[Marek Vasut]

On Monday, December 21, 2015 at 11:41:24 AM, Pavel Machek wrote:
> On Mon 2015-12-21 11:12:29, Marek Vasut wrote:
> > On Monday, December 21, 2015 at 10:37:23 AM, Pavel Machek wrote:
> > > On Mon 2015-12-21 07:33:34, 圣江 吴 wrote:
> > > > Hi Marek Vasut,
> > > > 
> > > > 
> > > > On Dec 18, 2015, at 04:50 AM, Marek Vasut <marex at denx.de> wrote:
> > > > 
> > > > On Friday, December 18, 2015 at 08:57:22 AM, 圣江 吴 wrote:
> > > > Hi Chin,
> > > > 
> > > > The PLL settings are copied from previous version
> > > > http://git.rocketboards.org/u-boot-socfpga.git,
> > > > 
> > > > This stuff should be generated by quartus, so why are you copying it
> > > > from some random version of u-boot somewhere ?
> > > > 
> > > > Thank you for your comment, if this configuration
> > > > is automatically generated by Quartus without manually modification,
> > > > then I would like to withdraw this patch.
> > > 
> > > No, please don't. socdk should work out of the box.
> > 
> > SoCDK works out of the box last time I checked (2016.01rc1), did you test
> > it recently and do you observe problems ?
> 
> Did you test QSPI? Because that is what subject claims does not work.

I'd have to retest that one, I only recall it booted and the basic functionality
was OK. Feel free to test QSPI again, that'd be actually helpful.

> > > I should not need
> > > quartus to build a working u-boot spl for the board.
> > 
> > You DO need quartus to generate the header files (that go into
> > board/nnn/qts) to build working U-Boot SPL for any board. I fail to
> > understand your comment, sorry.
> 
> Ok, lets talk about this personally or over phone.

Please stick to the ML.

Best regards,
Marek Vasut