[U-Boot] [PATCH] drivers: net: fsl_mc: Compare pointer value qbman_swp_mc_start
Pratiyush Mohan Srivastava
pratiyush.srivastava at freescale.com
Tue Dec 22 12:20:19 CET 2015
Current code compares the return pointer of function qbman_cena_write_start
with NULL. Instead the value of the return pointer should be compared.
Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava at freescale.com>
---
drivers/net/fsl-mc/dpio/qbman_portal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c
index 449ff8a..4b64c8a 100644
--- a/drivers/net/fsl-mc/dpio/qbman_portal.c
+++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
@@ -102,12 +102,14 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d)
void *qbman_swp_mc_start(struct qbman_swp *p)
{
void *ret;
+ int *return_val;
#ifdef QBMAN_CHECKING
BUG_ON(p->mc.check != swp_mc_can_start);
#endif
ret = qbman_cena_write_start(&p->sys, QBMAN_CENA_SWP_CR);
#ifdef QBMAN_CHECKING
- if (!ret)
+ return_val = (int *)ret;
+ if (!(*return_val))
p->mc.check = swp_mc_can_submit;
#endif
return ret;
--
1.9.1
More information about the U-Boot
mailing list