[U-Boot] [PATCH v3 04/17] arm: socfpga: sockit: Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS

[Marek Vasut]

On Wednesday, December 23, 2015 at 01:21:31 AM, Chin Liang See wrote:
> On Tue, 2015-12-22 at 21:28 +0100, Marek Vasut wrote:
> > On Tuesday, December 22, 2015 at 08:32:29 AM, Chin Liang See wrote:
> > > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI
> > > and UBIFS support on serial NOR flash
> > > 
> > > Signed-off-by: Chin Liang See <clsee at altera.com>
> > > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> > > Cc: Dinh Nguyen <dinh.linux at gmail.com>
> > > Cc: Pavel Machek <pavel at denx.de>
> > > Cc: Marek Vasut <marex at denx.de>
> > > Cc: Stefan Roese <sr at denx.de>
> > > ---
> > > 
> > >  configs/socfpga_sockit_defconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/configs/socfpga_sockit_defconfig
> > > b/configs/socfpga_sockit_defconfig index b4f41a9..dc32fe8 100644
> > > --- a/configs/socfpga_sockit_defconfig
> > > +++ b/configs/socfpga_sockit_defconfig
> > > @@ -25,3 +25,4 @@ CONFIG_DESIGNWARE_SPI=y
> > > 
> > >  CONFIG_DM_MMC=y
> > >  CONFIG_USB=y
> > >  CONFIG_DM_USB=y
> > > 
> > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n
> > 
> > Chin, would it be difficult to build your patchset before you submit
> > it?
> > This one builds with an obvious warning :'-(
> 
> That really strange as I built cyclone5, arria5, sockit, sr1500 and
> even mcvevk in case it break (as mcvevk dun have qspi). Wonder what is
> the build error you got?
> 
> FYI, here is my build info which indicate success build
> bash-3.2$ export CROSS_COMPILE=arm-altera-eabi-; make mrproper; make
> socfpga_sockit_defconfig; make

I fixed it in u-boot-socfpga/master, so it will compile fine, but you
should see a warning with the original patch, see at the end of this mail.

> [..]
>   CFG     spl/u-boot-spl.cfg
>   FDTGREP spl/u-boot-spl.dtb
>   CAT     spl/u-boot-spl-dtb.bin
>   MKIMAGE spl/u-boot-spl-dtb.sfp
> make[1]: warning:  Clock skew detected.  Your build may be incomplete.

This is a bit weird, isn't it ;-)

>   MKIMAGE u-boot.img
>   COPY    u-boot.dtb
>   CAT     u-boot-dtb.bin
>   MKIMAGE u-boot-dtb.img

[...]

> > There's buildman for doing such bulk builds, let me know if you need
> > help
> > setting it up.
> 
> That's sound good to me instead i invoke it manually every time. Let me
> take a look. A quick link would be much appreciated.

Thomas did a good concise writeup on setting up buildman:

http://www.mail-archive.com/u-boot@lists.denx.de/msg191914.html

> > I will drop this patch and fix the remaining three during
> > application, since
> > I want to get this set out of the door, but please do some better
> > testing
> > next time.
> 
> Do share you build error so I can simulate the build error.

CONFIG_SPI_FLASH_USE_4K_SECTORS was used twice in the config file sockit
config file (configs/socfpga_sockit) .