[U-Boot] [PATCH 5/8] spi: Move mode, mode_rx, flags macro's to structure

[Jagan Teki]

Hi Bin,

On 21 December 2015 at 11:18, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Jagan,
>
> On Wed, Dec 16, 2015 at 11:40 PM, Jagan Teki <jteki at openedev.com> wrote:
>> This patch moves mode, mode_rx, flags macro's to respective
>> member position on spi_slave{}, for better readabilty and
>> finding the respective member macro's easily.
>
> I am not in favor of mixing macros along with the structure members.
> This looks to me not clearer than before. Do we have some guideline
> anywhere?

Looks better readable and easily find the respective member macro's ie
the reason I have placed and I took the idea from Linux SPI core.

>
>>
>> This patch fix's the tab space on mode macro's as well.
>>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Michal Simek <michal.simek at xilinx.com>
>> Cc: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
>> Signed-off-by: Jagan Teki <jteki at openedev.com>
>> ---

thanks!
-- 
Jagan.