[U-Boot] [PATCH v5 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash

[Mugunthan V N]

On Wednesday 23 December 2015 05:02 PM, Jagan Teki wrote:
> On 23 December 2015 at 16:29, Mugunthan V N <mugunthanvnm at ti.com> wrote:
>> On Wednesday 23 December 2015 04:21 PM, Jagan Teki wrote:
>>> On 23 December 2015 at 15:29, Mugunthan V N <mugunthanvnm at ti.com> wrote:
>>>> Add compatible for spansion 32MiB spi flash s25fl256s1.
>>>>
>>>> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
>>>> ---
>>>>  drivers/mtd/spi/sf_probe.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>>>> index daa1d5b..c691b6c 100644
>>>> --- a/drivers/mtd/spi/sf_probe.c
>>>> +++ b/drivers/mtd/spi/sf_probe.c
>>>> @@ -166,6 +166,7 @@ static const struct dm_spi_flash_ops spi_flash_std_ops = {
>>>>
>>>>  static const struct udevice_id spi_flash_std_ids[] = {
>>>>         { .compatible = "spi-flash" },
>>>> +       { .compatible = "s25fl256s1" },
>>>>         { }
>>>
>>> I think we had discussion [1] to use spi-flash now and re-spin the
>>> things later - am I missing anything here?
>>>
>>> [1] https://patchwork.ozlabs.org/patch/546345/
>>>
>>
>> My assumption from the discussion is to add these compatibles for now
>> and when dts files are added with spi-flash compatible we can trim out
>> these compatibles.
> 
> I thought you understand it quite different, Please do what others do
> as of now means use spi-flash. and coming version will trim as
> compatible with Linux.
> 

you mean adding spi-flash compatible to dts file?

Regards
Mugunthan V N