[U-Boot] [PATCH 4/5] altera_qspi: show erase progress

Marek Vasut marex at denx.de
Thu Dec 24 04:02:24 CET 2015


On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote:
> Hi Marek,
> 
> On 2015年12月24日 09:29, Marek Vasut wrote:
> > On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote:
> >> Show sector erase progress with dot and comma.
> >> 
> >> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
> >> ---
> > 
> > Shouldn't this go into common code ?
> 
> The code to print a dot is minimal. It will cost more if this go into
> common code.

But then this driver behaves in a non-standard manner AND noone benefits
from this functionality but this driver.

> Alternatively, we might set the flash_verbose directly and remove the
> flash_set_verbose().
> 
> Best regards,
> Thomas

Best regards,
Marek Vasut


More information about the U-Boot mailing list