[U-Boot] [PATCH 1/8] sf: Add spi_flash_ids local to core

Jagan Teki jteki at openedev.com
Mon Dec 28 15:08:25 CET 2015


Hi Simon,

On 28 December 2015 at 09:52, Simon Glass <sjg at chromium.org> wrote:
> Hi Jagan,
>
> On 19 December 2015 at 07:13, Jagan Teki <jteki at openedev.com> wrote:
>> This patch add's spi_flash_ids handling into core, instead
>> of maintaining it into separate file like sf_params.c
>>
>> Code taken from the Linux spi-nor core and added missing
>> part id's and also added extra flash_info member as e_rd_cmd
>> for computing fastest read command.
>>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Michal Simek <michal.simek at xilinx.com>
>> Cc: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
>> Signed-off-by: Jagan Teki <jteki at openedev.com>
>> ---
>>  drivers/mtd/spi/spi_flash.c | 431 +++++++++++++++++++++++++++++++++++++-------
>>  include/linux/err.h         |   5 +
>>  2 files changed, 370 insertions(+), 66 deletions(-)
>
> I think there is too much going on in this patch for me to review
> it...will leave it to others.

Yes, because all changes depends one another, like struct flash_info,
spi_flash_ids and related changes.

thanks!
-- 
Jagan.


More information about the U-Boot mailing list