[U-Boot] [PATCH 1/2] spl: dm: Add SPL_DM_SEQ_ALIAS config option

Marek Vasut marex at denx.de
Wed Dec 30 10:02:29 CET 2015


On Wednesday, December 30, 2015 at 06:52:24 AM, Nathan Rossi wrote:
[...]
> > TBH I don't think this is the best solution. We should select things
> > which are required all the time. For zynq case this selection is
> > necessary just for qspi boot mode. There are other boot modes which
> > doesn't require it that's why for these mods this is just additional
> > code. If you think that this is need/good to select by default for your
> > SoC then this can be done separately.
> 
> Sorry for the slow response/follow up on this.
> 
> So as I understand it makes sense for this to be configured slightly
> differently depending on when the boot options that need this are
> available. I guess this also makes sense as SPI is not the only user
> of the seq alias feature.
> 
> I am sorting out v2 of this series for the additional patches to add
> the config for socfpga and mvebu, just want to clarify that this would
> be the preferred way (given recent comments) to enable it for the
> corresponding platforms:
>  * socfpga -> enable in each defconfig

If the feature is imperative for the platform to work, just enable it in
Kconfig too, just like on mvebu.

>  * mvebu -> enable in arch/arm/Kconfig for ARCH_MVEBU (aka auto selecting)
> 
> > Note: Agree with Marek that will be good to check where exactly the
> > problem is that this config option is necessary to enable even for case
> > where only on qspi is in the system.
> 
> I had a bit of a look into this, it would require changes to allow for
> it to fall-back to finding and using the first device which is matched
> for the uclass (instead of relying on just CONFIG_SF_DEFAULT_BUS), it
> would probably be an intrusive change to sf-uclass. A simpler solution
> might be to just default seq numbers to 0 when seq alias is not
> enabled? would allow for the change to work with other uclasses that
> use seq alias.
> 
> Regards,
> Nathan
> 
> > Acked-by: Michal Simek <michal.simek at xilinx.com>
> > 
> > Thanks,
> > Michal

Best regards,
Marek Vasut


More information about the U-Boot mailing list