[U-Boot] [PATCH 2/9] [v4] FIT: Modify option FIT_SIGNATURE in Kconfig

[Simon Glass]

Hi Ruchika,

On 30 December 2014 at 02:30, Ruchika Gupta <ruchika.gupta at freescale.com> wrote:
> For FIT signature based approach to work, RSA library needs to be selected. The FIT_SIGNATURE option in Kconfig is modified to automatically select RSA.
> Selecting RSA compiles the RSA library required for image verification.

Please word-wrap this.

Assuming you fix the two nits:

Acked-by: Simon Glass <sjg at chromium.org>

>
> Signed-off-by: Ruchika Gupta <ruchika.gupta at freescale.com>
> CC: Simon Glass <sjg at chromium.org>
> ---
> Changes in v4:
> Expanded CONFIG_RSA with documentation link
>
> Changes in v3:
> New patch created for adding Kconfig option for FIT signature
>
>  Kconfig     | 3 ++-
>  lib/Kconfig | 7 +++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index 153ee2b..c2d7cb9 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -116,8 +116,9 @@ config FIT_VERBOSE
>         depends on FIT
>
>  config FIT_SIGNATURE
> -       bool "Enabel signature verification of FIT uImages"
> +       bool "Enable signature verification of FIT uImages"
>         depends on FIT
> +       select RSA
>         help
>           This option enables signature verification of FIT uImages,
>           using a hash signed and verified using RSA.
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 8460439..2455f7a 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -27,4 +27,11 @@ config SYS_HZ
>           get_timer() must operate in milliseconds and this option must be
>           set to 1000.
>
> +config RSA
> +       bool "Use RSA Library"
> +       help
> +         RSA support.This enables the RSA algorithm used for FIT image

Space after '.'

> +         verification in U-Boot.
> +         See doc/uImage.FIT/signature.txt for more details.
> +
>  endmenu
> --
> 1.8.1.4
>

Regards,
Simon