[U-Boot] [PATCH 10/10] x86: config: chromebook_link: Enable environment

[Simon Glass]

Hi Bin,

On 4 January 2015 at 01:08, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Dec 30, 2014 at 9:12 AM, Simon Glass <sjg at chromium.org> wrote:
>> Enable an environment area.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  include/configs/chromebook_link.h | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/include/configs/chromebook_link.h b/include/configs/chromebook_link.h
>> index 22cb134..9b70435 100644
>> --- a/include/configs/chromebook_link.h
>> +++ b/include/configs/chromebook_link.h
>> @@ -68,6 +68,11 @@
>>  #define CONFIG_CMD_CROS_EC
>>  #define CONFIG_ARCH_EARLY_INIT_R
>>
>> +#undef CONFIG_ENV_IS_NOWHERE
>> +#define CONFIG_ENV_IS_IN_SPI_FLASH
>
> I don't see CONFIG_ENV_SIZE is defined anywhere. Will that work
> without CONFIG_ENV_SIZE?

That's in x86_common.h

>
>> +#define CONFIG_ENV_OFFSET              0x003f8000
>> +#define CONFIG_ENV_SECT_SIZE           256
>
> I think the CONFIG_ENV_SECT_SIZE should match the SPI flash sector size.

Ah yes I think this should be 4096.

Regards,
Simon