[U-Boot] [PATCH v3 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

[Heiko Schocher]

Hello Masahiro,

Am 26.12.2014 04:07, schrieb Masahiro Yamada:
> This commit adds on-chip I2C driver used on some old Panasonic
> UniPhier SoCs.
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v3: None
> Changes in v2:
>    - Fix a typo.  s/freqency/frequency/
>    - Add some comments to explain the formula calculating
>      wait time.
>    - add comments on every register
>    - skip stop condition if the next message is read
>
>   drivers/i2c/Kconfig        |  14 +++
>   drivers/i2c/Makefile       |   1 +
>   drivers/i2c/i2c-uniphier.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 248 insertions(+)
>   create mode 100644 drivers/i2c/i2c-uniphier.c
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index e69de29..6a479ef 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -0,0 +1,14 @@
> +config DM_I2C
> +	bool "Enable Driver Model for I2C drivers"
> +	depends on DM
> +	help
> +	  If you want to use driver model for I2C drivers, say Y.
> +	  To use legacy I2C drivers, say N.

This change seems not related to the "add driver for UniPhier i2c
controller" topic ...

Beside of that, you can add my

Acked-by: Heiko Schocher <hs at denx.de>

to the hole serie. I think this should go to the u-boot-dm tree from
Simon, as it depends on DM changes, or?

Simon? Is this OK for you?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany