[U-Boot] [PATCH 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

[Masahiro Yamada]

Hi Simon,



On Sat, 27 Dec 2014 10:32:38 -0700
Simon Glass <sjg at chromium.org> wrote:

> >
> > [2] It is difficult to describe alias register name for the same address.
> >
> > For example,
> >
> > #define I2C_DTTX        0x04            /* send FIFO */
> > #define I2C_DTRX        0x04            /* receive FIFO */
> >
> > DTTX is write-only register.
> > DTRX is read-only register.
> >
> > They are assigned to the same address.
> 
> You could use fifo or rx_tx or data. Of even a #define if you can't avoid it.
> 
> There has been quite a bit of discussion about this U-Boot design
> decision. I think Albert is the main expert.


Finally, I posted v4 using a structure for register access.



Best Regards
Masahiro Yamada