[U-Boot] [PATCH v2 05/11] videomodes: Add helper functions to parse video-mode env-var extra options

Anatolij Gustschin agust at denx.de
Thu Jan 8 16:40:35 CET 2015


On Fri, 19 Dec 2014 18:10:35 +0100
Hans de Goede <hdegoede at redhat.com> wrote:

> Add 2 helper functions to get strings, reps. ints from the options value
> returned by video_get_video_mode() / video_get_ctfb_res_modes().
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

before applying please fix these checkpatch warnings:

WARNING: space prohibited between function name and open parenthesis '('
#32: FILE: drivers/video/videomodes.c:116:
+video_get_param_len (const char *start, char sep)

WARNING: space prohibited between function name and open parenthesis '('
#58: FILE: drivers/video/videomodes.c:334:
+	while (p && (i = video_get_param_len (p, ',')) != 0) {

WARNING: space prohibited between function name and open parenthesis '('
#88: FILE: drivers/video/videomodes.c:364:
+	while (p && (i = video_get_param_len (p, ',')) != 0) {

total: 0 errors, 3 warnings, 0 checks, 77 lines checked

With these warnings fixed,

Acked-by: Anatolij Gustschin <agust at denx.de>




More information about the U-Boot mailing list