[U-Boot] [PATCH] usb: gadget: pxa25x_udc: fix use-before-initialized bug

[Marek Vasut]

On Thursday, January 08, 2015 at 07:19:35 PM, Nable wrote:

Hi!

> > You can use [PATCH RESEND], which is probably much clearer in expressing
> > the intent. You might add a short note just before the diffstat saying
> > that you only updated the SoB line and author to match the real deal,
> > but didn't change the patch contents.
> 
> I've edited my patch and it's still applies on to top HEAD of master
> branch, so I've sent fixed version to mailing list.

Thanks!

> Thank you for
> mentioning this idea of commentaries before diffstat output, I've never
> heard about it.

It's mostly useful to save reviewers the time figuring out what changed in
the patch and such message never propagates into the applied patch in the
tree :)

> > You can read [1] for the finer points of patch submission process, but
> > TL;DR
> > it's pretty much the same as Linux ;-)
> 
> Sounds like a nice joke! In fact, I'm doing my first steps in open-source
> software, so sending patches to Linux is something like a far dream.
> But if I reach that stage someday, then I'll be able to say that it's
> "pretty much the same as for U-Boot".

Heh, everyone's been there at some point. Good luck and have fun :)

> > [1] http://www.denx.de/wiki/U-Boot/Patches#General_Patch_Submission_Rules
> 
> I've studied [1] yesterday, and looked through it again today,
> so I hope that I'm doing everything in a right way this time.

Yeah, no worries. You'll quickly get the hang of it and someone will remind you
in case you screw up bigtime anyway ;-)

Best regards,
Marek Vasut