[U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i

[Ian Campbell]

On Sun, 2015-01-11 at 17:41 +0800, Chen-Yu Tsai wrote:
> On Sun, Jan 11, 2015 at 5:38 PM, Ian Campbell <ijc at hellion.org.uk> wrote:
> > On Sat, 2015-01-03 at 10:17 +0800, Chen-Yu Tsai wrote:
> >> ALDO2 is used to power LPDDR2 SDRAM on both the reference design and the
> >> Hummingbird A31, when this type of RAM is present.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
> >
> > I think this one needs Hans' opinion more than mine, but looks OK to me
> > with one small comment:
> >
> >> +     disable aldo2. On sun6i (A31) boards this is typically used for LPDDR2
> >> +     SDRAM, and should be set to 1.8V if present. On sun8i (A23) this is
> >> +     typically connected to VDD-DLL and must be set to 2.5V.
> >
> > It took me a while to work out why "set to 1.8V if present" wasn't
> > reflected in the default (which you changed to zero in this patch), I
> > think there is an implied "which is almost never" on the end? But that
> > wouldn't be in keeping with the style of things. How about:
> >
> >         [...] On sun6i (A31) boards this is typically unused and should
> >         be disabled, if it is used for LPDDR2 it should be set to 1.8V.
> >         [...]
> >
> > ?
> 
> Yes that does seem less confusing. A full stop after "disabled" would be
> even better.

I suppose either would work. I'll leave it to Hans to pick as he reviews
and/or commits it.

Ian.