[U-Boot] [PATCH v3 1/4] i2c: UniPhier: add driver for UniPhier i2c controller

Simon Glass sjg at chromium.org
Tue Jan 13 02:29:54 CET 2015


Hi,

On 5 January 2015 at 06:35, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Heiko,
>
> 2015-01-05 15:52 GMT+09:00 Heiko Schocher <hs at denx.de>:
>> Hello Masahiro,
>>
>> Am 26.12.2014 04:07, schrieb Masahiro Yamada:
>>
>>> This commit adds on-chip I2C driver used on some old Panasonic
>>> UniPhier SoCs.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>> Changes in v3: None
>>> Changes in v2:
>>>    - Fix a typo.  s/freqency/frequency/
>>>    - Add some comments to explain the formula calculating
>>>      wait time.
>>>    - add comments on every register
>>>    - skip stop condition if the next message is read
>>>
>>>   drivers/i2c/Kconfig        |  14 +++
>>>   drivers/i2c/Makefile       |   1 +
>>>   drivers/i2c/i2c-uniphier.c | 233
>>> +++++++++++++++++++++++++++++++++++++++++++++
>>>   3 files changed, 248 insertions(+)
>>>   create mode 100644 drivers/i2c/i2c-uniphier.c
>>>
>>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>>> index e69de29..6a479ef 100644
>>> --- a/drivers/i2c/Kconfig
>>> +++ b/drivers/i2c/Kconfig
>>> @@ -0,0 +1,14 @@
>>> +config DM_I2C
>>> +       bool "Enable Driver Model for I2C drivers"
>>> +       depends on DM
>>> +       help
>>> +         If you want to use driver model for I2C drivers, say Y.
>>> +         To use legacy I2C drivers, say N.
>>
>>
>> This change seems not related to the "add driver for UniPhier i2c
>> controller" topic ...
>
>
> OK, I can split it into two patches.
>
>
>
>
>
>> Beside of that, you can add my
>>
>> Acked-by: Heiko Schocher <hs at denx.de>
>>
>> to the hole serie. I think this should go to the u-boot-dm tree from
>> Simon, as it depends on DM changes, or?
>>
>> Simon? Is this OK for you?
>>
>
>
> I do not mind if Simon is willing to apply it to u-boot-dm.

Yes, that's fine. But please do cc me as otherwise I miss messages. So
much activity these days...

Regards,
Simon


More information about the U-Boot mailing list