[U-Boot] [PATCH v5 3/5] i2c: UniPhier: add driver for UniPhier FIFO-builtin i2c controller

Masahiro Yamada yamada.m at jp.panasonic.com
Tue Jan 13 04:51:28 CET 2015


Hi Simon,


On Mon, 12 Jan 2015 17:42:52 -0800
Simon Glass <sjg at chromium.org> wrote:

> Hi Masahiro,
> 
> On 8 January 2015 at 00:47, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> > This commit adds on-chip I2C driver used on newer SoCs of Panasonic
> > UniPhier platform.
> >
> > Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Acked-by: Heiko Schocher <hs at denx.de>
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> 
> A few nits below. If you prefer with the last two I can fix them when
> applying. The first one you probably don't want to change.


Thanks for your close review!

All of the three look nice, but I do not generally like local re-work.
I have sent v6 that is deregated to you.

When you find some time, please get it in via u-boot-dm.


And can you please apply this too?
http://patchwork.ozlabs.org/patch/415596/


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list