[U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition in "ifndef"

Masahiro Yamada yamada.m at jp.panasonic.com
Wed Jan 14 07:42:27 CET 2015


Hi Alexey,



On Wed, 14 Jan 2015 06:23:55 +0000
Alexey Brodkin <Alexey.Brodkin at synopsys.com> wrote:

> Hi Masahiro-san,
> 
> On Wed, 2015-01-14 at 13:12 +0900, Masahiro Yamada wrote:
> > On Fri, 9 Jan 2015 21:21:20 +0000
> > Alexey Brodkin <Alexey.Brodkin at synopsys.com> wrote:
> > I think this change is harmless, but
> > 
> > #define CONFIG_CMD_BDI   1
> > 
> > is simpler than
> > 
> > #ifndef CONFIG_CMD_BDI
> > #define CONFIG_CMD_BDI
> > #endif
> > 
> > 
> > Maybe?
> 
> I don't think so :)
> 
> Please look at Wolfgang's comment here
> http://lists.denx.de/pipermail/u-boot/2014-February/172494.html
> 
> --->8---
> Please do not define values for logical variables [please check
> everywhere].
> --->8---


Uh, OK.

Yours will do.



Best Regards
Masahiro Yamada



More information about the U-Boot mailing list