[U-Boot] [PATCHv1 15/22] arm: socfpga: spl: add relocate_stack_to_sdram to lowlevel_init.S

[Marek Vasut]

On Wednesday, January 14, 2015 at 05:40:55 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen at opensource.altera.com>
> 
> Add a function to relocate the stack from OCRAM to SDRAM.

Hi,

is this functionality really needed ? There's like 128 KiB of OCRAM on SoCFPGA,
which should be plenty, right? If moving the stack to SDRAM is really needed, 
then you might want to use the common stack relocation code (see relocate_code() 
function). Also, you should thoroughly describe the reason in the commit 
message, in this case it's really important.

Best regards,
Marek Vasut