[U-Boot] [PATCHv1 20/22] arm: socfpga: spl: add a malloc section in sram

[Marek Vasut]

On Wednesday, January 14, 2015 at 05:41:00 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen at opensource.altera.com>
> 
> Signed-off-by: Dinh Nguyen <dinguyen at altera.com>
> ---
>  arch/arm/cpu/armv7/socfpga/u-boot-spl.lds | 7 +++++++
>  include/configs/socfpga_common.h          | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/arm/cpu/armv7/socfpga/u-boot-spl.lds
> b/arch/arm/cpu/armv7/socfpga/u-boot-spl.lds index 739f3f1..f87e951 100644
> --- a/arch/arm/cpu/armv7/socfpga/u-boot-spl.lds
> +++ b/arch/arm/cpu/armv7/socfpga/u-boot-spl.lds
> @@ -45,6 +45,13 @@ SECTIONS
>  		__bss_end = .;
>  	} >.sram
> 
> +	.malloc :
> +	{
> +		. = . + CONFIG_SPL_MALLOC_SIZE;
> +		. = ALIGN(8);
> +		__malloc_start = .;
> +	} >.sram

The Malloc area should be handled by the common SPL linker script I believe.
Can you switch to the common linker script please ?

>  	.stack :
>  	{
>  		. = . + CONFIG_SPL_STACK_SIZE;
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index 29d02d6..6185d12 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -306,6 +306,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>  #define CONFIG_SYS_SPL_MALLOC_SIZE	256
>  #define CONFIG_SPL_MAX_SIZE		(64 * 1024)
>  #define CONFIG_SPL_STACK_SIZE		0x1000
> +#define CONFIG_SPL_MALLOC_SIZE		(5 * 1024)

This is some a dangling part of the patch I suspect ? The previous patch
changed CONFIG_SYS_SPL_MALLOC_SIZE, now you're adding CONFIG_(without 
_SYS)_SPL_MALLOC_SIZE . Somehow this is strange.

>  #define CHUNKSZ_CRC32			(1 * 1024)	/* FIXME: ewww */
>  #define CONFIG_CRC32_VERIFY

Best regards,
Marek Vasut