[U-Boot] [PATCH 09/12] sunxi: mmc: Use a realistic timeout when sending a mmc command

Ian Campbell ijc at hellion.org.uk
Sat Jan 17 23:54:51 CET 2015


On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote:
> Wait 1 second for the sdcard to respond, rather then waiting for
> 0xfffff milliseconds.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Acked-by: Ian Campbell <ijc at hellion.org.uk>

(needn't wait for the rest of the series I think)

> ---
>  drivers/mmc/sunxi_mmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> index 6234981..ee8ad5c 100644
> --- a/drivers/mmc/sunxi_mmc.c
> +++ b/drivers/mmc/sunxi_mmc.c
> @@ -355,7 +355,8 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>  		}
>  	}
>  
> -	error = mmc_rint_wait(mmc, 0xfffff, SUNXI_MMC_RINT_COMMAND_DONE, "cmd");
> +	timeout_msecs = 1000;

Not strictly necessary to go via the variable, but not harmful either.

> +	error = mmc_rint_wait(mmc, timeout_msecs, SUNXI_MMC_RINT_COMMAND_DONE, "cmd");
>  	if (error)
>  		goto out;
>  




More information about the U-Boot mailing list