[U-Boot] [RFC PATCH 3/5] common/board_r: manual relocation for cmd table

Andreas Bießmann andreas.devel at googlemail.com
Tue Jan 20 00:41:54 CET 2015


Hi Simon,

On 20.01.15 00:34, Simon Glass wrote:
> Hi Andreas,
> 
> On 19 January 2015 at 16:29, Andreas Bießmann
> <andreas.devel at googlemail.com> wrote:
>> This is required for architectures still need manual relocation like avr32, mk68
>> and others.
>>
>> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
>> ---
>>
>>  common/board_r.c |   12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/common/board_r.c b/common/board_r.c
>> index a301cc2..e712902 100644
>> --- a/common/board_r.c
>> +++ b/common/board_r.c
>> @@ -294,6 +294,15 @@ static int initr_announce(void)
>>         return 0;
>>  }
>>
>> +#ifdef CONFIG_NEEDS_MANUAL_RELOC
>> +static int initr_manual_reloc_cmdtable(void)
>> +{
>> +       fixup_cmdtable(ll_entry_start(cmd_tbl_t, cmd),
>> +                      ll_entry_count(cmd_tbl_t, cmd));
>> +       return 0;
>> +}
>> +#endif
>> +
>>  #if !defined(CONFIG_SYS_NO_FLASH)
>>  static int initr_flash(void)
>>  {
>> @@ -718,6 +727,9 @@ init_fnc_t init_sequence_r[] = {
>>         initr_serial,
>>         initr_announce,
>>         INIT_FUNC_WATCHDOG_RESET
>> +#ifdef CONFIG_NEEDS_MANUAL_RELOC
>> +       initr_manual_reloc_cmdtable,
>> +#endif
>>  #ifdef CONFIG_PPC
>>         initr_trap,
>>  #endif
>> --
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Why do you need manual reloc? Is this a toolchain bug?

Just not implemented yet for avr32. It is on my list, but avr32 has not
my highest priority ;)
As long as there are other arches which need this also I think it is
some more time to shift ... the generic board deadline end of 2014 was a
bit stricter, I don't want to kick avr32 out of u-boot now. So let's get
generic board working for avr32 in the next release ;)

Best regards

Andreas Bießmann


More information about the U-Boot mailing list