[U-Boot] [PATCH] pci: tegra: Fix port information parsing

Bin Meng bmeng.cn at gmail.com
Wed Jan 21 17:07:51 CET 2015


Hi Thierry,

On Wed, Jan 21, 2015 at 5:50 PM, Thierry Reding <treding at nvidia.com> wrote:
> On Tue, Jan 20, 2015 at 06:06:53PM +0100, Sjoerd Simons wrote:
>> commit a62e84d7b1824a202dd incorrectly changed the tegra pci code to the
>> new fdtdec pci helpers. To get the device index of the root port, the
>> "reg" property should be parsed from the dtb (as was previously the
>> case).
>>
>> With this patch i can successfully network boot my jetson tk1
>>
>> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
>> ---
>>  drivers/pci/pci_tegra.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> Given the discussion here and in
>
>         http://patchwork.ozlabs.org/patch/430815/
>
> I agree with Bin that this is a more appropriate fix. The documentation
> of the fdtdec_get_pci_bdf() function could be improved, in my opinion,
> to mention how the compatible property is involved. That should clarify
> that any value in "reg" can be overridden by looking up the allocated
> bus number after enumeration.

I can prepare a patch to improve the doc.

>
> So this patch:
>
> Tested-by: Thierry Reding <treding at nvidia.com>
> Acked-by: Thierry Reding <treding at nvidia.com>

Regards,
Bin


More information about the U-Boot mailing list