[U-Boot] [PATCH 2/3] x86: Save mtrr support flag in global data

Bin Meng bmeng.cn at gmail.com
Wed Jan 21 17:17:05 CET 2015


Hi Simon,

On Thu, Jan 22, 2015 at 12:05 AM, Simon Glass <sjg at chromium.org> wrote:
> On 19 January 2015 at 22:01, Bin Meng <bmeng.cn at gmail.com> wrote:
>> CPUID (EAX 01H) returns MTRR support flag in EDX bit 12. Probe this
>> flag in x86_cpu_init_f() and save it in global data.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  arch/x86/cpu/cpu.c                 | 7 +++++++
>>  arch/x86/include/asm/global_data.h | 3 ++-
>>  2 files changed, 9 insertions(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
>> -       int mtrr_req_count;
>> +       int     mtrr_req_count;
>> +       int     has_mtrr;
>
> But I don't think we need the tabs after 'int'.
>

Looks that there is a tab before hob_list, so I chose tab to indent
these two. I will send a v2 patch to fix this.

Regards,
Bin


More information about the U-Boot mailing list