[U-Boot] [PATCH 03/10][v6] DM: crypto/rsa_mod_exp: Add rsa Modular Exponentiation DM driver

[Simon Glass]

Hi Ruchika,

On 26 January 2015 at 06:39, Simon Glass <sjg at chromium.org> wrote:
> Hi Ruchika,
>
> On 23 January 2015 at 03:31, Ruchika Gupta <ruchika.gupta at freescale.com> wrote:
>> Add a new rsa uclass for performing modular exponentiation and implement
>> the software driver basing on this uclass.
>>
>> Signed-off-by: Ruchika Gupta <ruchika.gupta at freescale.com>
>> CC: Simon Glass <sjg at chromium.org>
>> ---
>> Changes in v6:
>> No Changes
>>
>> Changes in v5:
>> Changed UCLASS name to UCLASS_MOD_EXP
>>
>> Changes in v4:
>> Removed Kconfig option for DM_RSA
>> Corrected driver name for sw rsa driver
>> Updated the rsa_mod_exp operation to have output length
>>
>> Changes in v3:
>> New patch with driver model for RSA UCLASS
>>
>>  drivers/crypto/Makefile                     |  1 +
>>  drivers/crypto/rsa_mod_exp/Kconfig          |  5 ++++
>>  drivers/crypto/rsa_mod_exp/Makefile         |  7 ++++++
>>  drivers/crypto/rsa_mod_exp/mod_exp_sw.c     | 39 +++++++++++++++++++++++++++++
>>  drivers/crypto/rsa_mod_exp/mod_exp_uclass.c | 31 +++++++++++++++++++++++
>>  include/dm/uclass-id.h                      |  1 +
>>  include/u-boot/rsa-mod-exp.h                | 34 ++++++++++++++++++++++++-
>>  7 files changed, 117 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/crypto/rsa_mod_exp/Kconfig
>>  create mode 100644 drivers/crypto/rsa_mod_exp/Makefile
>>  create mode 100644 drivers/crypto/rsa_mod_exp/mod_exp_sw.c
>>  create mode 100644 drivers/crypto/rsa_mod_exp/mod_exp_uclass.c
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> Just in case there is a v7:
>
>> +++ b/drivers/crypto/rsa_mod_exp/mod_exp_uclass.c
>> @@ -0,0 +1,31 @@
>> +/*
>> + * (C) Copyright 2014 Freescale Semiconductor, Inc
>> + * Author: Ruchika Gupta <ruchika.gupta at freescale.com>
>> + *
>> + * SPDX-License-Identifier:    GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <dm.h>
>> +#include <u-boot/rsa-mod-exp.h>
>> +#include <errno.h>
>> +#include <fdtdec.h>
>> +#include <malloc.h>
>> +#include <asm/io.h>
>> +#include <linux/list.h>
>> +
>
> You can trim headers here.

There are a few nits I mentioned in your patches.

To avoid further delay and testing I would like to pick these patches
up as is, but if you like you could send a follow-on patch.

Regards,
Simon