[U-Boot] [PATCH v5] Export redesign

Wolfgang Denk wd at denx.de
Mon Jan 26 15:45:31 CET 2015


Dear Simon,

In message <1422279795-3052-1-git-send-email-sjg at chromium.org> you wrote:
> From: Martin Dorwig <dorwig at tetronik.com>
> 
> this is an atempt to make the export of functions typesafe.
> I replaced the jumptable void ** by a struct (jt_funcs) with function pointers.
> The EXPORT_FUNC macro now has 3 fixed parameters and one
> variadic parameter
> The first is the name of the exported function,
> the rest of the parameters are used to format a functionpointer
> in the jumptable,
> 
> the EXPORT_FUNC macros are expanded three times,
> 1. to declare the members of the struct
> 2. to initialize the structmember pointers
> 3. to call the functions in stubs.c
> 
> Signed-off-by: Martin Dorwig <dorwig at tetronik.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> (resending to the list since my tweaks are not quite trivial)

Is this a 100% binary compatible change?  If not, should we not also
increment XF_VERSION ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where people stand is not as important as which way they face.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_


More information about the U-Boot mailing list