[U-Boot] [PATCH v2 1/3] ti: davinci: Remove unnecessary stack and global_data fiddles

Simon Glass sjg at chromium.org
Mon Jan 26 17:55:26 CET 2015


The stack is already set to CONFIG_SPL_STACK immediately before
board_init_f() is called, so this should not be needed.

Also global_data has already been set up so we don't want to mess with
it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2: None

 arch/arm/cpu/arm926ejs/davinci/spl.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c
index 59b304e..f8caf2a 100644
--- a/arch/arm/cpu/arm926ejs/davinci/spl.c
+++ b/arch/arm/cpu/arm926ejs/davinci/spl.c
@@ -36,9 +36,6 @@ void putc(char c)
 
 void board_init_f(ulong dummy)
 {
-	/* First, setup our stack pointer. */
-	asm volatile("mov sp, %0\n" : : "r"(CONFIG_SPL_STACK));
-
 	/* Second, perform our low-level init. */
 #ifdef CONFIG_SOC_DM365
 	dm36x_lowlevel_init(0);
@@ -50,8 +47,7 @@ void board_init_f(ulong dummy)
 	/* Third, we clear the BSS. */
 	memset(__bss_start, 0, __bss_end - __bss_start);
 
-	/* Finally, setup gd and move to the next step. */
-	gd = &gdata;
+	/* Finally, move to the next step. */
 	board_init_r(NULL, 0);
 }
 
-- 
2.2.0.rc0.207.ga3a616c



More information about the U-Boot mailing list