[U-Boot] [PATCH v2 07/10] dm: i2c: s3c24x0: adjust to dm-i2c api

Przemyslaw Marczak p.marczak at samsung.com
Tue Jan 27 09:01:25 CET 2015


Hello Simon,

On 01/27/2015 04:13 AM, Simon Glass wrote:
> Hi Przemyslaw,
>
> On 26 January 2015 at 08:21, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
>> This commit adjusts the s3c24x0 driver to new i2c api
>> based on driver-model. The driver supports standard
>> and high-speed i2c as previous.
>>
>> Tested on Trats2, Odroid U3, Arndale, Odroid XU3
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Heiko Schocher <hs at denx.de>
>> Cc: Minkyu Kang <mk7.kang at samsung.com>
>>
>
> Tested on snow:
>
> Tested-by: Simon Glass <sjg at chromium.org>
>
> This looks right to me, but I have a number of nits, mostly code that
> can be deleted, Please see below.
>
> If you can respin this I will pick it up.
>

Thank you for the review, I will fix the issues and resend this today.

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list