[U-Boot] [U-Boot, v2] spl: Change debug to printf for "Unsupported boot-device"

Michal Simek monstr at monstr.eu
Tue Jan 27 15:40:06 CET 2015


2015-01-27 15:38 GMT+01:00 Stefan Roese <sr at denx.de>:

> On 27.01.2015 15:22, Tom Rini wrote:
>
>> We had the problem on an AM33xx platform, that SPL detected an
>>>>> unsupported boot-device. But since this message is a debug message
>>>>> it took a bit of time to really know, where the hangup in SPL
>>>>> resulted from. So let's change this debug message to a printf
>>>>> and also print the detected boot-device that is not supported.
>>>>> This makes debugging of such cases much easier.
>>>>>
>>>>> Signed-off-by: Stefan Roese <sr at denx.de>
>>>>> Cc: Wolfgang Denk <wd at denx.de>
>>>>> Cc: Tom Rini <trini at ti.com>
>>>>> Acked-by: Heiko Schocher <hs at denx.de>
>>>>>
>>>>
>>>> Applied to u-boot/master, thanks!
>>>>
>>>>
>>>>  This patch is causing problem on Microblaze because SPL exceed 4k
>>> limit.
>>> It is only one printf which is called in entire SPL that's why this
>>> should
>>> be solved a little bit differently.
>>>
>>
>> OK, but for clarity you need and are using both
>> CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because
>> you're using puts but not printf, yes?
>>
>
> Right. If this is the case (only puts usage on Microblaze), then its
> perhaps best that I change this line to puts as well. Okay?
>
>
Changing this to puts is definitely fine. Microblaze is using just puts.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


More information about the U-Boot mailing list