[U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout

[Simon Glass]

Hi,

On 27 January 2015 at 05:36, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
> If no device is connected to I2C bus, the i2c probe command
> can take a lot of time for probe each address. This commit
> reduces the busy timeout to 10ms for standard and high speed
> modes. This doesn't break the transmission an also allow for
> properly probe the devices.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>

Tested-by: Simon Glass <sjg at chromium.org>

This patch looks OK but I'd like to get other comments if possible.

>
> Changes v3:
> - new commit, after split the next one
> ---
>  drivers/i2c/s3c24x0_i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index fd328f0..3129c7f 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -111,9 +111,9 @@
>  #define I2C_START_STOP 0x20    /* START / STOP */
>  #define I2C_TXRX_ENA   0x10    /* I2C Tx/Rx enable */
>
> -#define I2C_TIMEOUT_MS 1000            /* 1 second */
> +#define I2C_TIMEOUT_MS 10              /* 10 ms */
>
> -#define        HSI2C_TIMEOUT_US 100000 /* 100 ms, finer granularity */
> +#define        HSI2C_TIMEOUT_US 10000 /* 10 ms, finer granularity */
>
>
>  /* To support VCMA9 boards and other who dont define max_i2c_num */
> --
> 1.9.1
>

Regards,
Simon