[U-Boot] [PATCH 01/10][v6] rsa: Split the rsa-verify to separate the modular exponentiation

Simon Glass sjg at chromium.org
Wed Jan 28 21:08:50 CET 2015


On 26 January 2015 at 06:39, Simon Glass <sjg at chromium.org> wrote:
> On 23 January 2015 at 03:31, Ruchika Gupta <ruchika.gupta at freescale.com> wrote:
>> Public exponentiation which is required in rsa verify functionality is
>> tightly integrated with verification code in rsa_verify.c. The patch
>> splits the file into twp separating the modular exponentiation.
>>
>> 1. rsa-verify.c
>> - The file parses device tree keys node to fill a keyprop structure.
>> The keyprop structure can then be converted to implementation specific
>> format.
>> (struct rsa_pub_key for sw implementation)
>> - The parsed device tree node is then passed to a generic rsa_mod_exp
>> function.
>>
>> 2. rsa-mod-exp.c
>> Move the software specific functions related to modular exponentiation
>> from rsa-verify.c to this file.
>>
>> Signed-off-by: Ruchika Gupta <ruchika.gupta at freescale.com>
>> CC: Simon Glass <sjg at chromium.org>
>> ---
>> Changes in v6:
>> No changes
>>
>> Changes in v5:
>> Reverted change in rsa_mod_exp_sw function to add pointer to output length
>> Addressed other comments by Simon
>>
>> Changes in v4:
>> Modified rsa_mod_exp_sw function to add pointer to output length
>>
>> Changes in v3:
>> Kconfig moved to separate patch. This patch just splits the file now
>>
>> Changes in v2:
>> Addressed few of Simon Glass's comments:
>> - Kconfig option added for RSA
>> - Comments added for new keyprop struct
>>
>>  include/u-boot/rsa-mod-exp.h |  43 ++++++
>>  lib/rsa/Makefile             |   2 +-
>>  lib/rsa/rsa-mod-exp.c        | 303 +++++++++++++++++++++++++++++++++++++++
>>  lib/rsa/rsa-verify.c         | 329 ++++++++-----------------------------------
>>  tools/Makefile               |   3 +-
>>  5 files changed, 404 insertions(+), 276 deletions(-)
>>  create mode 100644 include/u-boot/rsa-mod-exp.h
>>  create mode 100644 lib/rsa/rsa-mod-exp.c
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list