[U-Boot] [PATCH v2 08/22] x86: Rename MMCONF_BASE_ADDRESS and make it common across x86

Simon Glass sjg at chromium.org
Thu Jan 29 00:44:01 CET 2015


On 27 January 2015 at 22:36, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Wed, Jan 28, 2015 at 1:13 PM, Simon Glass <sjg at chromium.org> wrote:
>> This setting will be used by more than just ivybridge so make it common.
>>
>> Also rename it to PCIE_ECAM_BASE which is a more descriptive name.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> Please see one minor issue below.
>
>> Changes in v2:
>> - Rename MMCONF_BASE_ADDRESS to PCIE_ECAM_BASE
>> - Adjust the Kconfig help according to Bin's comments
>>
>>  arch/x86/Kconfig                                  | 14 ++++++++++++++
>>  arch/x86/cpu/ivybridge/sdram.c                    |  2 +-
>>  arch/x86/include/asm/arch-ivybridge/sandybridge.h |  2 +-
>>  board/google/chromebook_link/Kconfig              |  3 +--
>>  4 files changed, 17 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 90e828a..bda7a0e 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -356,4 +356,18 @@ source "board/google/chromebook_link/Kconfig"
>>
>>  source "board/intel/crownbay/Kconfig"
>>
>> +config PCIE_ECAM_BASE
>> +       hex
>> +        default 0xe0000000
>
> Need make 'default' aligned. Sorry I did not point it out in the v1
> review. You can fix it when applying.
>

Fixed.

Applied to u-boot-x86.


More information about the U-Boot mailing list