[U-Boot] [PATCH 19/23] x86: spi: Support ValleyView in ICH SPI driver

[Simon Glass]

Hi Bin,

On 27 January 2015 at 23:02, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Wed, Jan 28, 2015 at 1:17 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Bin,
>>
>> On 27 January 2015 at 07:00, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Tue, Jan 27, 2015 at 9:23 AM, Simon Glass <sjg at chromium.org> wrote:
>>>> The base address is found in a different way and the protection bit is also
>>>> in a different place. Otherwise it is very similar.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> ---
>>>>
>>>>  drivers/spi/ich.c | 56 ++++++++++++++++++++++++++++++++++++++++---------------
>>>>  drivers/spi/ich.h | 11 ++++++-----
>>>>  2 files changed, 47 insertions(+), 20 deletions(-)
>>
>> Just a note on this one...for v2 I have done nothing. I think we
>> should move it to device tree as you say but it needs some more
>> thought, as we have register offsets and device types to think about.
>> I will try a few things and test on link also. Once I have this I will
>> send a v3. So this patch will have to sit here until that is done,
>> hopefully only a few days.
>>
>
> OK, I think we can just apply this patch for now along with other
> patches in this series. We can revisit this driver when adding DT and
> DM support.

Oh OK we can do it that way. I actually have some partial work to
convert the ICH driver to DM, so I'll go back to that soon.

Applied to u-boot-x86.

Regards,
Simon