[U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

Joe Hershberger joe.hershberger at gmail.com
Fri Jan 30 17:19:29 CET 2015


On Fri, Jan 30, 2015 at 4:04 AM, Marek Vasut <marex at denx.de> wrote:
>
> On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote:
> > Hi Marek, Tom,
> >
> > On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote:
> > > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> > > > If for some reason DMA module fails to reset user oserves only this:
> > > > --->---
> > > > # dhcp
> > > > Trying dwmac.e0018000
> > > > FAIL
> > > > --->---
> > > >
> > > > This message makes not much sense.
> > > > With proposed change error message will be more helpful:
> > > > --->---
> > > > # dhcp
> > > > Trying dwmac.e0018000
> > > > DMA reset timeout
> > > > FAIL
> > > > --->---
> > > >
> > > > For example user may do power toggle to recover board functionality.
> > > >
> > > > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > > > Cc: Chin Liang See <clsee at altera.com>
> > > > Cc: Dinh Nguyen <dinguyen at altera.com>
> > > > Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> > > > Cc: Tom Rini <trini at ti.com>
> > > > Cc: Wolfgang Denk <wd at denx.de>
> > >
> > > Acked-by: Pavel Machek <pavel at denx.de>
> >
> > Any chance for this trivial change to be applied?
>
> Joe, can you please pick this ?

Sure.

-Joe


More information about the U-Boot mailing list