[U-Boot] [PATCH 05/13] lcd: atmel: introduce lcd_logo_set_cmap

Simon Glass sjg at chromium.org
Sat Jan 31 01:24:36 CET 2015


On 29 January 2015 at 04:21, Nikita Kiryanov <nikita at compulab.co.il> wrote:
> Reduce the bitmap_plot #ifdef complexity by extracting Atmel specific code for
> setting cmap into a new function lcd_logo_set_cmap(), which is implemented in
> atmel_lcdfb driver and defined as part of common/lcd.c api with a weak dummy
> version. In the Atmel implementation, ARRAY_SIZE(bmp_logo_palette) is
> switched for BMP_LOGO_COLORS to avoid having to include bmp_logo_data.h, which
> would cause a compilation error because the logo data and palette arrays would
> be defined twice.
>
> This is a step towards cleaning bitmap_plot() of platform specific code.
>
> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
> Cc: Bo Shen <voice.shen at atmel.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Anatolij Gustschin <agust at denx.de>
> ---
>  common/lcd.c                | 29 ++++++++---------------------
>  drivers/video/atmel_lcdfb.c | 26 ++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+), 21 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list