[U-Boot] [PATCH v2 1/2] pci: Configure expansion ROM during auto config process

Simon Glass sjg at chromium.org
Wed Jul 1 01:17:14 CEST 2015


Hi Bin,

On 22 June 2015 at 21:45, Bin Meng <bmeng.cn at gmail.com> wrote:
> Currently PCI expansion ROM address is assigned by a call to
> pciauto_setup_rom() outside of the pci auto config process.
> This does not work when expansion ROM is on a device behind
> PCI bridge where bridge's memory limit register was already
> programmed to a value that does not cover the newly assigned
> expansion ROM address. To fix this, we should configure the
> ROM address during the auto config process.

Well I should have known that approach would not work :-(

>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
>
> Changes in v2:
> - Handle header type 1 ROM address programming
>
>  drivers/pci/pci_auto.c | 48 ++++++++++++++++++++++--------------------------
>  drivers/pci/pci_rom.c  |  5 -----
>  include/pci.h          |  9 ---------
>  3 files changed, 22 insertions(+), 40 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list