[U-Boot] Marvell Armada XP SATA support

Stefan Roese sr at denx.de
Wed Jul 1 17:19:24 CEST 2015


Hi Anton,

On 01.07.2015 17:09, Anton Schubert wrote:
>         Additionally, what would you recommend for the MVEBU_SATA_BASE
>         define as
>         it would be ambiguous after the a38x patch.
>
>
>     Why not just use the same name/macro?
>
> I think it would be a bit confusing with MVEBU_SATA0_BASE for A38X and
> MVEBU_SATA_BASE for AXP in the same header. (As I don't have access to
> the A38X Spec I don't know how similar they really are)

Do the addresses differ? If not, then please use the same macro and 
perhaps add a comment, that on AXP this is not AHCI compatible. And on 
A38x it is.

If the addresses differ, I suggest to use a name like:

MVEBU_AXP_SATA_BASE

Thanks,
Stefan



More information about the U-Boot mailing list