Vignesh wrote... [snip] > +#define BIT(x) (1 << (x)) > + Is this not something that would be better in a global header file somewhere rather than it starting a trend of a per-driver, per-arch, etc. definitions? Andy.