[U-Boot] [PATCH 02/11] imx: mx6ul: Add pins IOMUX head file

[Marek Vasut]

On Friday, July 03, 2015 at 03:31:09 AM, Peng Fan wrote:
> Hi, Marek
> 
> On Thu, Jul 02, 2015 at 08:29:20PM +0200, Marek Vasut wrote:
> >On Thursday, July 02, 2015 at 01:02:59 PM, Peng Fan wrote:
> >> Add i.MX6UL pins IOMUX file which defines the IOMUX settings for choose.
> >> 
> >> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
> >> Signed-off-by: Ye.Li <B37916 at freescale.com>
> >> ---
> >> 
> >>  arch/arm/include/asm/arch-mx6/mx6-pins.h   |    2 +
> >>  arch/arm/include/asm/arch-mx6/mx6ul_pins.h | 1065
> >> 
> >> ++++++++++++++++++++++++++++ 2 files changed, 1067 insertions(+)
> >> 
> >>  create mode 100644 arch/arm/include/asm/arch-mx6/mx6ul_pins.h
> >> 
> >> diff --git a/arch/arm/include/asm/arch-mx6/mx6-pins.h
> >> b/arch/arm/include/asm/arch-mx6/mx6-pins.h index 534f780..4b6bb18 100644
> >> --- a/arch/arm/include/asm/arch-mx6/mx6-pins.h
> >> +++ b/arch/arm/include/asm/arch-mx6/mx6-pins.h
> >> @@ -37,6 +37,8 @@ enum {
> >> 
> >>  #include "mx6sl_pins.h"
> >>  #elif defined(CONFIG_MX6SX)
> >>  #include "mx6sx_pins.h"
> >> 
> >> +#elif defined(CONFIG_MX6UL)
> >> +#include "mx6ul_pins.h"
> >> 
> >>  #else
> >>  #error "Please select cpu"
> >>  #endif	/* CONFIG_MX6Q */
> >
> >Would it be possible to build a single image for an entire MX6 lineup
> >of CPUs ? I think it is now possible to build a single image for MX6
> >Quad/Dual/DualLite/Solo ... do SX and UL integrate well into this too?
> >Seeing this patch, I don't think so ...
> 
> A single image you mean like linux kernel, one image cover all the
> arch/driver code, and using dts to cover board part?

Eventually yes, but this can be done without DT too.

> If so, agree to build a single image for i.MX6, but dtb is not added now.
> To kernel, pinmux header are used for dtb, but now we do need this file
> to set pinmux in uboot board file.

See arch/arm/include/asm/arch-mx6/mx6-pins.h and in particular CONFIG_MX6QDL
option. It allows defining pins for both MX6Q and DL (and solo), thus you can
build single image for a board which might use all three options. I think
it should be possible to add SX and UL into this mix too.

> SX and UL have different pinmux from others.

OK

> >> diff --git a/arch/arm/include/asm/arch-mx6/mx6ul_pins.h
> >> b/arch/arm/include/asm/arch-mx6/mx6ul_pins.h new file mode 100644
> >> index 0000000..c92b4f0
> >
> >How very different is this from Solo or SoloX ? Is the pinmux map
> >really that different that it needs a new file of it's own (I did
> >not check) ?
> 
> SX and UL have different pinmux map.

OK

Best regards,
Marek Vasut