[U-Boot] [PATCH 07/55] exynos: i2c: Correct bug in pinmux selection

Simon Glass sjg at chromium.org
Mon Jul 6 17:27:24 CEST 2015


Hi Minkyu, Przemyslaw,

On 5 July 2015 at 00:15, Heiko Schocher <hs at denx.de> wrote:
> Hello Simon,
>
> Am 03.07.2015 um 02:15 schrieb Simon Glass:
>>
>> When driver model is not used the current code does not correctly select
>> the pinmux for the I2C bus. This bug was introduced by this commit:
>>
>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>   drivers/i2c/s3c24x0_i2c.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Acked-by: Heiko Schocher <hs at denx.de>
>
> As it is a bugfix, this should go in the current release ... right?

Minkyu, are you able to pick this up please? If not I can do it.

Przemyslaw can you please review this fix?

Regards,
Simon

>
> bye,
> Heiko
>>
>>
>> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
>> index c053e84..9a04e48 100644
>> --- a/drivers/i2c/s3c24x0_i2c.c
>> +++ b/drivers/i2c/s3c24x0_i2c.c
>> @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int
>> node_list[], int count,
>>
>> CONFIG_SYS_I2C_S3C24X0_SPEED);
>>                 bus->node = node;
>>                 bus->bus_num = i;
>> -               exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags);
>> +               exynos_pinmux_config(bus->id, flags);
>>
>>                 /* Mark position as used */
>>                 node_list[i] = -1;
>>
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list