[U-Boot] [PATCH 07/55] exynos: i2c: Correct bug in pinmux selection

[Przemyslaw Marczak]

Hello Simon,

On 07/03/2015 02:15 AM, Simon Glass wrote:
> When driver model is not used the current code does not correctly select
> the pinmux for the I2C bus. This bug was introduced by this commit:
>
> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api

Ah that's right, thanks for fixing!

>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   drivers/i2c/s3c24x0_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index c053e84..9a04e48 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int node_list[], int count,
>   						CONFIG_SYS_I2C_S3C24X0_SPEED);
>   		bus->node = node;
>   		bus->bus_num = i;
> -		exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags);
> +		exynos_pinmux_config(bus->id, flags);
>
>   		/* Mark position as used */
>   		node_list[i] = -1;
>

Reviewed-by: Przemyslaw Marczak <p.marczak at samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com