[U-Boot] [PATCH v2 7/8] mtd/nand/ubi: assortment of alignment fixes

Scott Wood scottwood at freescale.com
Thu Jul 9 01:25:33 CEST 2015


On Wed, 2015-07-08 at 13:58 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> 
> Various U-Boot adoptions/extensions to MTD/NAND/UBI did not take buffer
> alignment into account which led to failures of the following form:
> 
> ERROR: v7_dcache_inval_range - start address is not aligned - 0x1f7f0108
> ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1f7f1108
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> ---
> Changes in v2: run it through checkpatch.pl and fix long lines
> 
>  common/cmd_ubi.c             | 2 +-
>  drivers/mtd/nand/nand_util.c | 2 +-
>  fs/ubifs/super.c             | 6 ++++--
>  fs/ubifs/ubifs.c             | 5 +++--
>  lib/gzip.c                   | 2 +-
>  5 files changed, 10 insertions(+), 7 deletions(-)

As per discussion on v1, this isn't enough to guarantee that the stop address 
will be aligned.  There needs to be a wrapper around memalign() that cache-
aligns the size as well.

-Scott



More information about the U-Boot mailing list