[U-Boot] [PATCH] nand: lpc32xx: add SLC NAND controller support

Vladimir Zapolskiy vz at mleia.com
Wed Jul 15 10:49:01 CEST 2015


Hello Albert,

On 15.07.2015 10:05, Albert ARIBAUD wrote:
> Hello Vladimir,
> 
> On Tue, 14 Jul 2015 23:23:57 +0300, Vladimir Zapolskiy <vz at mleia.com>
> wrote:
>> The change adds support of LPC32xx SLC NAND controller.
>> 
>> LPC32xx SoC has two different mutually exclusive NAND controllers 
>> to communicate with single and multiple layer chips.
>> 
>> This simple driver allows to specify NAND chip timings and defines
>>  custom read_buf()/write_buf() operations, because access to 8-bit 
>> data register must be 32-bit aligned.
>> 
>> Support of hardware ECC calculation is not implemented (data 
>> correction is always done by software), since it requires a working
>> DMA engine.
>> 
>> The driver can be included to an SPL image.
> 
> This is needed for an upcoming new board support patch, right?

you are correct, I plan to extend current support of devkit3250 board.

> If so, then I suggest you put together all patches for this new
> board in a single series. This will make it clear(er) you're not
> adding dead code here.
> 

I got the point, I will be able to complete board specific changes today
tonight and send them for review.

Please let me ask you for one more advice, if I want to add peripherals
support on the board (by the way thank you for your drivers) and SPL
image building support, both changes touch defconfig and board config
header files. Should I split these changes into separate ones or is one
"board support extension" patch preferred?

--
With best wishes,
Vladimir


More information about the U-Boot mailing list