[U-Boot] [PATCH] cmd_fdt: save fdtaddr in hex format

Simon Glass sjg at chromium.org
Mon Jul 20 15:25:44 CEST 2015


On 16 July 2015 at 10:34, Simon Glass <sjg at chromium.org> wrote:
> On 16 July 2015 at 07:26, Linus Walleij <linus.walleij at linaro.org> wrote:
>> On Fri, Jul 10, 2015 at 6:18 PM, Sudeep Holla <sudeep.holla at arm.com> wrote:
>>
>>> Commit 90fbee3e4051 ("cmd_fdt: Actually fix fdt command in sandbox")
>>> changed the format(from hex address to unsigned long) in which "fdtaddr"
>>> is saved . However do_fdt continues reads the "fdtaddr" assuming it to
>>> be in hex format. This may lead to fdt being either loaded or attempted
>>> to load at erroneous address generating fault if the address is out of
>>> memory.
>>>
>>> This patch changes back the format to hex while saving the "fdtaddr"
>>> as it was done before.
>>>
>>> Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
>>> Cc: Linus Walleij <linus.walleij at linaro.org>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> Cc: Hua Yanghao <huayanghao at gmail.com>
>>> Cc: Heiko Schocher <hs at denx.de>
>>
>> Looks like the right fix:
>> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>>
>> Yours,
>> Linus Walleij
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-fdt, thanks!


More information about the U-Boot mailing list