[U-Boot] [PATCH] x86: Fix RTC build error on ivybridge

[Simon Glass]

Hi Bin,

On 21 July 2015 at 15:06, Albert ARIBAUD <albert.u.boot at aribaud.net> wrote:
> Hello Bin,
>
> On Tue, 21 Jul 2015 20:21:28 +0800, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Albert,
>>
>> On Tue, Jul 21, 2015 at 8:19 PM, Albert ARIBAUD
>> <albert.u.boot at aribaud.net> wrote:
>> > Hello Bin,
>> >
>> > On Tue, 21 Jul 2015 00:55:13 -0700, Bin Meng <bmeng.cn at gmail.com> wrote:
>> >> For some unknown reason, buildman does not report build error
>> >> when building commit 06c4b7e. This commit is to correct the
>> >> build error and needs to be squashed into commit 06c4b7e.

You can use -C to force a reconfigure after every build. Otherwise it
defaults to an incremental build which will not reconfigure. It
automatically reconfigures if it gets an error, but does not look for
errors. This case is rare enough that I don't worry about it too much.

>> >
>> > Which repository and branch contains this commit 06c4b7e?
>> > I cannot find it at all under u-boot/master.
>>
>> It is on the u-boot-x86/master.
>
> Ok, thanks.
>
>> > Besides, fixes are not done by squashing commit.
>> >
>>
>> Yep, I know that once something goes into mainline, it is not allowed
>> to change any history. As this is on the u-boot-x86/master and Simon
>> has not asked Tom to pull, I believe it is OK.
>
> Fine then.
>
>> Regards,
>> Bin
>
> Amicalement,
> --
> Albert.

Acked-by: Simon Glass <sjg at chromium.org>

Regards,
Simon