[U-Boot] [PATCH 03/48] dm: serial: Correct logic in serial_find_console_or_panic()

[Bin Meng]

On Wed, Jul 22, 2015 at 11:48 PM, Simon Glass <sjg at chromium.org> wrote:
> In a final attempt to find a console UART this function uses the first
> first available serial device. However the check for a valid device is
> inverted.
>
> This code is only executed when there is in fact no serial UART, but at
> present it can fail to reach the panic_str() call in this case, and start
> trying to use a non-existent UART.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  drivers/serial/serial-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
> index 815fec3..bbc366b 100644
> --- a/drivers/serial/serial-uclass.c
> +++ b/drivers/serial/serial-uclass.c
> @@ -71,7 +71,7 @@ static void serial_find_console_or_panic(void)
>  #endif
>                 if (!uclass_get_device_by_seq(UCLASS_SERIAL, INDEX, &dev) ||
>                     !uclass_get_device(UCLASS_SERIAL, INDEX, &dev) ||
> -                   (!uclass_first_device(UCLASS_SERIAL, &dev) || dev)) {
> +                   (!uclass_first_device(UCLASS_SERIAL, &dev) && dev)) {
>                         gd->cur_serial_dev = dev;
>                         return;
>                 }
> --

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>