[U-Boot] [PATCH] arm: mvebu: add multiple usb-hostcontroller support for AXP

Stefan Roese sr at denx.de
Thu Jul 23 14:35:08 CEST 2015


Hi Anton,

(added Marek to Cc, as he's the USB custodian)

On 23.07.2015 14:25, Anton Schubert wrote:
> This patch adds support for multiple hostcontrollers to the ehci-marvell driver
> and enables all 3 usb-hcs on the db-mv784mp-gp board.
>
> It depends on the initial Armada XP usb support patch from Stefan.
>
> Signed-off-by: Anton Schubert <anton.schubert at gmx.de>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Luka Perkov <luka.perkov at sartura.hr>

Thanks. But this patch will not apply once my latest patches from 
yesterday and today are applied. Please see below:

> ---
>   drivers/usb/host/ehci-marvell.c | 23 ++++++++++++-----------
>   include/configs/db-mv784mp-gp.h |  1 +
>   2 files changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-marvell.c b/drivers/usb/host/ehci-marvell.c
> index 826e7f7..6548cb2 100644
> --- a/drivers/usb/host/ehci-marvell.c
> +++ b/drivers/usb/host/ehci-marvell.c
> @@ -22,7 +22,8 @@
>   DECLARE_GLOBAL_DATA_PTR;
>
>   #define rdl(off)	readl(MVUSB0_BASE + (off))
> -#define wrl(off, val)	writel((val), MVUSB0_BASE + (off))
> +#define wrl(port, off, val)	writel((val), MVUSB0_BASE + (off) + \
> +	((port) << 12))

I've removed the wrl() accessor funtion from this file:

https://patchwork.ozlabs.org/patch/498431/

So please rebase this patch on top of this version. You can add my:

Reviewed-by: Stefan Roese <sr at denx.de>

then as well. :)

Thanks,
Stefan



More information about the U-Boot mailing list