[U-Boot] [PATCH V2 5/6] P2571: dts: Add DT files for Tegra210/P2571 board

[Tom Warren]

Stephen,

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Thursday, July 23, 2015 11:00 AM
> To: Tom Warren
> Cc: u-boot at lists.denx.de; Thierry Reding; Stephen Warren;
> tomcwarren3959 at gmail.com
> Subject: Re: [U-Boot] [PATCH V2 5/6] P2571: dts: Add DT files for
> Tegra210/P2571 board
> 
> On 07/23/2015 11:44 AM, Tom Warren wrote:
> > Stephen,
> >
> >> -----Original Message-----
> >> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> >> Sent: Wednesday, July 22, 2015 11:17 AM
> >> To: Tom Warren
> >> Cc: u-boot at lists.denx.de; Thierry Reding; Stephen Warren;
> >> tomcwarren3959 at gmail.com
> >> Subject: Re: [U-Boot] [PATCH V2 5/6] P2571: dts: Add DT files for
> >> Tegra210/P2571 board
> >>
> >> On 07/20/2015 01:50 PM, Tom Warren wrote:
> >>> Based on T124 Venice2. SDMMC1 is SD-card slot.
> >>
> >>>    arch/arm/dts/{tegra124.dtsi => tegra210.dtsi}      | 153 ++++-----------------
> >>
> >> There's also a lot of stuff in that file that isn't used in U-Boot or
> >> isn't validated yet (audio, SPI?, PWM, I2C?, APBDMA, PCIe). I'd
> >> suggest trimming the DT down to the absolute bare minimum for what
> >> U-Boot is using right now. That will help prevent any inconsistencies
> >> between the U-Boot and kernel DT files for Tegra210.
>  >
> > Audio, PCIE make sense. UART and SPI both have DMA properties, so I can' t
> remove APBDMA. I'll do a cleanup run and see what shakes out.
> 
> I believe the DMA properties should be optional in the bindings for UART and
> SPI. So, you should be able to remove the DMA properties from the client
> nodes and hence also the APBDMA node. (Especially given that the U-Boot
> drivers those HW blocks don't do DMA).
If they're optional, why are they in tegra124.dtsi? (and T114 and T30). I wonder how they got in there originally?

Regardless, I'll remove 'em from T210 if you feel that strongly about it.

--
nvpublic