[U-Boot] [PATCH 47/48] x86: Gracefully disable the vesa driver when running from EFI

[Bin Meng]

Hi Simon,

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

But please see nits below.

On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass <sjg at chromium.org> wrote:
> We cannot use this driver when running from EFI as we have no direct hardware
> access. Coreboot uses a different driver which uses tables provided by

coreboot. I don't see any official name with a capital C.

> Coreboot. So far it does not seem possible to use a normal video driver when

coreboot

> booting from EFI.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  drivers/video/vesa_fb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/video/vesa_fb.c b/drivers/video/vesa_fb.c
> index 909f8e8..7a93443 100644
> --- a/drivers/video/vesa_fb.c
> +++ b/drivers/video/vesa_fb.c
> @@ -24,6 +24,14 @@ void *video_hw_init(void)
>         int ret;
>
>         printf("Video: ");
> +       if (!ll_boot_init()) {
> +               /*
> +                * If we are running from EFI or Coreboot, this driver can't

coreboot

> +                * work.
> +                */
> +               printf("Not available (previous bootloader prevents it)\n");
> +               return NULL;
> +       }
>         if (vbe_get_video_info(gdev)) {
>                 dev = pci_find_class(PCI_CLASS_DISPLAY_VGA << 8, 0);
>                 if (dev == -1) {
> --

Regards,
Bin